Skip to content

fix(api): list every question type in the API description - #3950

Merged
Chartman123 merged 1 commit into
mainfrom
fix/openapi-question-types
Nov 21, 2026
Merged

Chartman123 merged 1 commit into
mainfrom
fix/openapi-question-types

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

The FormsQuestionType enum of the API description lacked linearscale, color and ranking, although the API creates and returns questions of these types. A client generated from openapi.json could not create them and rejected forms that hold one. The psalm type is completed and openapi.json regenerated.

Found in the review of #3637.

How to verify

composer openapi produces no diff, and the FormsQuestionType enum in openapi.json lists all question types of Constants::ANSWER_TYPES.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

The question types of the API description lacked the linear scale, the
color and the ranking, although the API creates and returns questions
of these types. A client generated from openapi.json could not create
them and rejected forms that hold one.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added bug Something isn't working 3. to review Waiting for reviews labels Nov 21, 2026
@AndyScherzinger AndyScherzinger added this to the 5.5 milestone Nov 21, 2026
@AndyScherzinger

Copy link
Copy Markdown
Member Author

/backport to stable5.4

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Nov 21, 2026
Chartman123

This comment was marked as duplicate.

@Chartman123
Chartman123 merged commit 455f345 into main Nov 21, 2026
52 checks passed
@Chartman123
Chartman123 deleted the fix/openapi-question-types branch November 21, 2026 08:02
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants